Open moedn opened 1 year ago
I was just taking a look here and I found that commit id "working on MDR" is repeated. Should this be considered a bug then?
jepp, that seems to be the issue :+1:
if I replace the ID with "further work on MDR", it renders correctly. otherwise mermaid doesn't seem to have an issue with repetitive commit IDs
I have used mermaid, but never really looked into the code base. But I have experience with D3 and SVGs in general. Can I pick this up, and give it a try?
PS: this is my first shot at open source contribution
Is this actually the bug that needs addressing? Or is it more that Mermaid should have an issue with repeated/duplication commit IDs?
Commit IDs should be unique generally, of course. But I think the "cherry-pick" feature in Mermaid would mean the IDs need to be unique for that feature to work.
With unique IDs:
gitGraph
commit
branch develop
checkout develop
commit id:"hello"
commit id:"world"
checkout main
commit
cherry-pick id:"hello"
gitGraph
commit
branch develop
checkout develop
commit id:"hello"
commit id:"world"
checkout main
commit
cherry-pick id:"hello"
With duplicate IDs:
gitGraph
commit
branch develop
checkout develop
commit id:"hello"
commit id:"hello"
checkout main
commit
cherry-pick id:"hello"
[NOTE: 2 commits now become 1]
gitGraph
commit
branch develop
checkout develop
commit id:"hello"
commit id:"hello"
checkout main
commit
cherry-pick id:"hello"
Perhaps there's a feature request underlying this -- to have a commit "message:" parameter in the syntax too, which can be duplicated, while IDs remain unique
Description
First of all: thanks for this amazing project! I use mermaid a lot :)
I'm trying to visualize the branch management for an open source MRI project, but the rendering has a glitch after a certain point (see code samples below)
Steps to reproduce
code sample before break
from belowcomplete code sample
working on MDR
inFORK-v1.0-MDR
comes beforeminor design changes for MDR
inv1-rc
, but appears after the merge in the rendered imageScreenshots
before break:
complete:
Code Sample