`d3-shape`, `d3-path`, `d3-array` are bundled multiple times

mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown

https://mermaid.js.org

MIT License

71k stars 6.38k forks source link

`d3-shape`, `d3-path`, `d3-array` are bundled multiple times #4872

Open tommoor opened 1 year ago

tommoor commented 1 year ago

Description

d3-shape, d3-path, d3-array are bundled multiple times causing the size of the library to be ~50Kb larger than it needs to be (larger than most libraries are to begin with).

Steps to reproduce

Look in pnpm-lock

Screenshots

Setup

Mermaid version: 10.4.0

Yokozuna59 commented 1 year ago

Hi @tommoor, thanks for reporting, we're already aware of the issue and waiting for https://github.com/d3/d3-sankey/pull/117 to be merged, see https://github.com/d3/d3-sankey/pull/117#issuecomment-1676670147.

tommoor commented 1 year ago

Feel free to close as duplicate, but it seems like the maintainer of d3-sankey isn't planning on merging that PR – any thoughts on a way forward? 😢

Yokozuna59 commented 1 year ago

@tommoor I'm not really sure if there's a good solution for such an issue. I wouldn't recommend creating a script to be executed in each install process to remove the old version.

tommoor commented 1 year ago

https://pnpm.io/package_json#pnpmoverrides should be the way to go if the dependencies are otherwise compatible