mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
71.18k stars 6.41k forks source link

Resolves E2E testing issues and issue #5343 #5344

Closed rowanfr closed 7 months ago

rowanfr commented 7 months ago

:bookmark_tabs: Summary

This resolves E2E testing commit ID consistency issues with some git graph tests

Resolves #5343

:straight_ruler: Design Decisions

This is an immensely basic PR that resolves commit ID consistency issues in E2E tests by giving them constant IDs for testing

:clipboard: Tasks

Make sure you

netlify[bot] commented 7 months ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 1b0b1227b62089a48e676623a32b1ab770504028
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e07d252bf5b6000898c757
Deploy Preview https://deploy-preview-5344--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.37%. Comparing base (1857eb1) to head (1b0b122).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## develop #5344 +/- ## ============================================ - Coverage 76.47% 43.37% -33.11% ============================================ Files 160 23 -137 Lines 14014 5130 -8884 Branches 820 23 -797 ============================================ - Hits 10717 2225 -8492 + Misses 3118 2904 -214 + Partials 179 1 -178 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `?` | | | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `43.37% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more. [see 156 files with indirect coverage changes](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)
mermaid-bot[bot] commented 7 months ago

@rowanfr, Thank you for the contribution! You are now eligible for a year of Premium account on MermaidChart. Sign up with your GitHub account to activate.