mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
71.18k stars 6.41k forks source link

build(deps): update `langium` to `v3` and apply the required changes #5345

Closed Yokozuna59 closed 7 months ago

Yokozuna59 commented 7 months ago

:bookmark_tabs: Summary

By the update langium to v3, it should decrease the parser package size by around 1/3rd of the bundle, see: https://github.com/eclipse-langium/langium/pull/1258#issuecomment-1907410628.

This PR would be consider as a BREAKING CHANGE in the mermaid-js/parser package, because we export the modified interfaces and functions.

:straight_ruler: Design Decisions

Applied the changes description in https://github.com/eclipse-langium/langium/pull/1258#issuecomment-1909737014 and https://github.com/eclipse-langium/langium/blob/18a38cedb427d36bb955dd854548e9173955b2f8/packages/langium/CHANGELOG.md#smaller-bundles-with-exports.

replace the calls of createDefault[Shared]Module by createDefault[Shared]CoreModule, and adapt the imports accordingly. That's basically it wrt. to this PR.

:clipboard: Tasks

Make sure you

netlify[bot] commented 7 months ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 171a2019ec15bec91a46592d8ebf798cf16306e2
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e17b302f8773000859ad6a
Deploy Preview https://deploy-preview-5345--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.67%. Comparing base (70df6bb) to head (171a201).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5345/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## next #5345 +/- ## ======================================= Coverage 44.67% 44.67% ======================================= Files 25 25 Lines 5339 5339 Branches 27 27 ======================================= Hits 2385 2385 Misses 2953 2953 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Ξ” | | |---|---|---| | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `44.67% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more.
sidharthv96 commented 7 months ago

next

-rw-r--r--@ 1 sidv  staff   5.8M Mar  1 12:24 dist/mermaid.js
-rw-r--r--@ 1 sidv  staff   2.5M Mar  1 12:24 dist/mermaid.min.js
image

v3

-rw-r--r--@ 1 sidv  staff   5.2M Mar  1 12:23 dist/mermaid.js
-rw-r--r--@ 1 sidv  staff   2.2M Mar  1 12:23 dist/mermaid.min.js
image