Open FutzMonitor opened 3 months ago
Name | Link |
---|---|
Latest commit | d1a3a84b6f472d7d469780bd567b30aa086af6ee |
Latest deploy log | https://app.netlify.com/sites/mermaid-js/deploys/660864333b1c540008668f85 |
Deploy Preview | https://deploy-preview-5399--mermaid-js.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 5.74%. Comparing base (
8e95c4d
) to head (d1a3a84
).
:bookmark_tabs: Summary
This pull request removes the hashtag from the title, section, and event regex so that hashtags can be used in their text content. The period element were not included because of an inconsistency. Whereas you can put a hashtag anywhere in the string for a title, section, and event, the period element begins a line and thus is counted as comment.
These changes were made to allow for hashtags in the timeline diagram and to address the inconsistency between percent comments and hashtag comments. This way functionality isn't outright broken with a new comment notation
##
versus#
.Resolves #5356 .
:straight_ruler: Design Decisions
I simply removed the hashtag symbol from the exclusion clause regex for the title, section, and event. I made sure to add test coverage to the timeline test suite and run
pnpm test
to ensure that it was still working.:clipboard: Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch