search

mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
71.14k stars 6.41k forks source link

Convert gitGraph to TS #5407

Open NicolasCwy opened 6 months ago

NicolasCwy commented 6 months ago

:bookmark_tabs: Summary

Brief description about the content of your PR.

Resolves #

:straight_ruler: Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

:clipboard: Tasks

Make sure you

netlify[bot] commented 6 months ago

Deploy Preview for mermaid-js failed.

Name Link
Latest commit d464a6b413b9a421fd337972411730ec2f261309
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65feb85b92a8220008dbcf34
NicolasCwy commented 6 months ago

@sidharthv96 Hey sidharth would you know if this .hash is used? I don't see this for other diagrams so I have a feeling this is legacy code that I can remove

https://github.com/mermaid-js/mermaid/blob/d464a6b413b9a421fd337972411730ec2f261309/packages/mermaid/src/diagrams/git/gitGraphAst.ts#L214-L221

sidharthv96 commented 6 months ago

Yes, you can remove that hash.

NicolasCwy commented 6 months ago

@sidharthv96 Can the old git graph renderer be removed? I don't see any references to it