mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
71.14k stars 6.41k forks source link

fix: make sequenceDB typesafe #5426

Closed ad1992 closed 5 months ago

ad1992 commented 6 months ago

:bookmark_tabs: Summary

:clipboard: Tasks

Make sure you

netlify[bot] commented 6 months ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 2a3d03254df5b37af0ea37805f5cd69e51a1d61b
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661a250253a3190008426909
Deploy Preview https://deploy-preview-5426--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 5.74%. Comparing base (9ed2f4b) to head (2a3d032).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## develop #5426 +/- ## ========================================== - Coverage 5.74% 5.74% -0.01% ========================================== Files 276 276 Lines 41886 41902 +16 Branches 514 514 ========================================== Hits 2407 2407 - Misses 39479 39495 +16 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `5.74% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [.eslintrc.cjs](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426?src=pr&el=tree&filepath=.eslintrc.cjs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-LmVzbGludHJjLmNqcw==) | `0.00% <0.00%> (ø)` | | | [packages/mermaid/src/utils/imperativeState.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Futils%2FimperativeState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvdXRpbHMvaW1wZXJhdGl2ZVN0YXRlLnRz) | `0.00% <0.00%> (ø)` | | | [...ckages/mermaid/src/diagrams/sequence/sequenceDb.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5426?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fsequence%2FsequenceDb.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvc2VxdWVuY2Uvc2VxdWVuY2VEYi50cw==) | `0.00% <0.00%> (ø)` | |
ad1992 commented 5 months ago

friendly reminder @sidharthv96 ^