mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
68.75k stars 6.08k forks source link

bug(ClassDiagram): Fixed a combination abstract and static modifiers not working. #5462

Open TeaDrinkingProgrammer opened 2 months ago

TeaDrinkingProgrammer commented 2 months ago

:bookmark_tabs: Summary

This pull requests fixes a combination of abstract and static modifiers not working.

Resolves #5459

:straight_ruler: Design Decisions

I updated the RegEx for detecting methods to take into account a possible combination of $* instead of just * or $. In that process I also found out that the last capture group didn't do anything because a "hack" was used where it checked if the last character was $ or *. This was removed.

For the fields, a similar tactic of checking for the first and last characters was replaced with a RegEx similar to the first one.

:clipboard: Tasks

Make sure you

netlify[bot] commented 2 months ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 582d774ac9de6e81c66be68fe218d9f8e9ea0600
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661ec13f52e29e0008c9705e
Deploy Preview https://deploy-preview-5462--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 5.73%. Comparing base (e570863) to head (582d774). Report is 58 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## develop #5462 +/- ## ========================================== - Coverage 5.74% 5.73% -0.02% ========================================== Files 277 278 +1 Lines 41897 41999 +102 Branches 489 490 +1 ========================================== Hits 2407 2407 - Misses 39490 39592 +102 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Ξ” | | |---|---|---| | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `5.73% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Ξ” | | |---|---|---| | [packages/mermaid/src/diagrams/class/classTypes.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fclass%2FclassTypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvY2xhc3MvY2xhc3NUeXBlcy50cw==) | `0.00% <0.00%> (ΓΈ)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5462/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)
TeaDrinkingProgrammer commented 1 month ago

Is there anything I can do to get this PR merged?