Open TeaDrinkingProgrammer opened 2 months ago
Name | Link |
---|---|
Latest commit | 582d774ac9de6e81c66be68fe218d9f8e9ea0600 |
Latest deploy log | https://app.netlify.com/sites/mermaid-js/deploys/661ec13f52e29e0008c9705e |
Deploy Preview | https://deploy-preview-5462--mermaid-js.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 0%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 5.73%. Comparing base (
e570863
) to head (582d774
). Report is 58 commits behind head on develop.
Is there anything I can do to get this PR merged?
:bookmark_tabs: Summary
This pull requests fixes a combination of abstract and static modifiers not working.
Resolves #5459
:straight_ruler: Design Decisions
I updated the RegEx for detecting methods to take into account a possible combination of
$*
instead of just*
or$
. In that process I also found out that the last capture group didn't do anything because a "hack" was used where it checked if the last character was $ or *. This was removed.For the fields, a similar tactic of checking for the first and last characters was replaced with a RegEx similar to the first one.
:clipboard: Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features. --> Will add an issue later for documentation.develop
branch