Closed NicolasNewman closed 1 month ago
Name | Link |
---|---|
Latest commit | 22bd26272d7de937321a68347c5dd6160ec30d82 |
Latest deploy log | https://app.netlify.com/sites/mermaid-js/deploys/6638eedcdfb9d20008a8e64c |
Deploy Preview | https://deploy-preview-5483--mermaid-js.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 0%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 5.72%. Comparing base (
e68125e
) to head (22bd262
).
:bookmark_tabs: Summary
Resolves #5435
:straight_ruler: Design Decisions
1)
As mentioned in the PR, differences between the default fonts for each OS was not taken into account when I implemented the
useLegacyMathML
config option. As a result, there is currently no way to force Mermaid to fallback to using KaTeX's stylesheets if they are provided. To allow this to be done, I added an additional config optionforceLegacyMathML
to explicitly tell Mermaid to default to CSS-based rendering.Ideally this should be changed to a single config option that takes one of 3 values but I don't know what the protocol for deprecating config options are.
2)
While fixing the above I noticed the spacing for some equations in flowchart vertices were incorrect. This was due to an erroneous
<br />
tags being added by the regex replacementvertexText.replace(/\\n|\n/g, '<br />')
being triggered on unintended line breaks in the template string inrenderKatex()
.Before:
![image](https://github.com/mermaid-js/mermaid/assets/16135852/fd028a59-db34-496b-8b06-1f05713be304)
After:
![image](https://github.com/mermaid-js/mermaid/assets/16135852/647865de-7ab3-4f53-9cf0-b9a05e7da412)
:clipboard: Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch