mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
71.11k stars 6.4k forks source link

[WIP] refactor: make sequence/svgDraw typesafe #5484

Open ad1992 opened 5 months ago

ad1992 commented 5 months ago

:bookmark_tabs: Summary

Brief description about the content of your PR.

Resolves #

:straight_ruler: Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

:clipboard: Tasks

Make sure you

netlify[bot] commented 5 months ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit c5b35355612afc43498bded64184b0cb8ceab72a
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/662793e123f18e00081b97f7
Deploy Preview https://deploy-preview-5484--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 360 lines in your changes are missing coverage. Please review.

Project coverage is 5.71%. Comparing base (3809732) to head (c5b3535).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## develop #5484 +/- ## ========================================== - Coverage 5.72% 5.71% -0.01% ========================================== Files 278 277 -1 Lines 42013 42083 +70 Branches 490 515 +25 ========================================== Hits 2407 2407 - Misses 39606 39676 +70 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `5.71% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [.../mermaid/src/diagrams/sequence/sequenceRenderer.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fsequence%2FsequenceRenderer.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvc2VxdWVuY2Uvc2VxdWVuY2VSZW5kZXJlci50cw==) | `0.00% <0.00%> (ø)` | | | [...kages/mermaid/src/diagrams/common/svgDrawCommon.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fcommon%2FsvgDrawCommon.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvY29tbW9uL3N2Z0RyYXdDb21tb24udHM=) | `0.00% <0.00%> (ø)` | | | [packages/mermaid/src/diagrams/sequence/svgDraw.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fsequence%2FsvgDraw.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvc2VxdWVuY2Uvc3ZnRHJhdy50cw==) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5484/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)