Closed igorwessel closed 1 month ago
Name | Link |
---|---|
Latest commit | da150e8767eab63ef9e95be73a6696f34ffca161 |
Latest deploy log | https://app.netlify.com/sites/mermaid-js/deploys/6638ba5d184fe10008ebd40c |
Deploy Preview | https://deploy-preview-5503--mermaid-js.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 4.54545%
with 42 lines
in your changes are missing coverage. Please review.
Project coverage is 5.73%. Comparing base (
e68125e
) to head (da150e8
).
@igorwessel, Thank you for the contribution! You are now eligible for a year of Premium account on MermaidChart. Sign up with your GitHub account to activate.
@sidharthv96 could we include it in a minor release? I can do a double-check and look to see if any breaking changes were introduced.
Current develop has breaking changes, slotted for v11. So we'll have to extract your changes and rebase onto master to make a new release. We are only doing v10 security releases now.
:bookmark_tabs: Summary
The ID of the from-to relationship was added to the diagram's edges. Another denominator "_" was used to make the extraction of these respective IDs easier.
:straight_ruler: Design Decisions
I am currently working on converting state diagram to Excalidraw, and I felt the need to have an easier way to find the edges.
I tried some alternative paths but without success, for example:
.edgePaths
, however, the index does not always reflect how we iterate through the parser.doc.graphCount
id to get the edge, but in cases where we have multiple relationships for the same state, it may not find the correct edge because we do not have access to thegraphCount
in the parser.doc, only to the node id.:clipboard: Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch