mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
68.69k stars 6.07k forks source link

Flowchart edges not found: Diagram db `getEdges` returining edges which aren't drawn on DOM #5516

Closed ad1992 closed 1 week ago

ad1992 commented 1 month ago

Description

Diagram db getEdges sometimes returns edges which aren't drawn or DOM for flowchart

Steps to reproduce

Let's consider the 👇🏻 mermaid code

flowchart TB   
    subgraph conference
        frontend
        backend
        security
    end
    frontend --> |Dive into frontend frameworks| conference
    backend --> |Learn all about backend| conference
    security --> |securing web apps| conference

For the above this 👇🏻 is the mermaid output

Screenshot 2024-05-13 at 12 49 47 PM

As its clear that none of the edges are drawn even though the diagram db getEdges returns 👇🏻

[
    {
        "start": "frontend",
        "end": "conference",
        "type": "arrow_point",
        "text": "Dive into frontend frameworks",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    },
    {
        "start": "backend",
        "end": "conference",
        "type": "arrow_point",
        "text": "Learn all about backend",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    },
    {
        "start": "security",
        "end": "conference",
        "type": "arrow_point",
        "text": "securing web apps",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    }
]

So this should be fixed in the code so that the getEdges returns correct set of edges

Screenshots

No response

Code Sample

No response

Setup

Suggested Solutions

No response

Additional Context

No response

nirname commented 1 week ago

@ad1992 I am closing this issue because it seems that you had already fixed it, but merging PR did not closed the issue, because you had had to use magic comment like "resolves #issue_number"