search

mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
68.69k stars 6.07k forks source link

Update flowchart.md #5517

Closed GRASBOCK closed 1 month ago

GRASBOCK commented 1 month ago

fix callback by setting the window callback to the respective callback function in the jsfiddle and code sample

:bookmark_tabs: Summary

The documentation jsfiddle on flowchart interaction doesn't work, because the callback function is not added. I fixed the code samples and the jsfiddle and replaced the old jsfiddle with a link to the new one.

Resolves #5510

:straight_ruler: Design Decisions

Saved a new jsfiddle that contains the change and made the changes in the markdown of the docs.

:clipboard: Tasks

Make sure you

netlify[bot] commented 1 month ago

Deploy Preview for mermaid-js ready!

Name Link
Latest commit 6d2939c9b9e7452fedae52e7df5b88052a77e954
Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66459606e0165b00087212a5
Deploy Preview https://deploy-preview-5517--mermaid-js.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0.97143% with 1733 lines in your changes are missing coverage. Please review.

Project coverage is 5.73%. Comparing base (c562ca0) to head (356e520). Report is 15 commits behind head on master.

:exclamation: Current head 356e520 differs from pull request most recent head 6d2939c. Consider uploading reports for the commit 6d2939c to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517/graphs/tree.svg?width=650&height=150&src=pr&token=BaET4V1BdM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) ```diff @@ Coverage Diff @@ ## master #5517 +/- ## ========================================= - Coverage 5.74% 5.73% -0.01% ========================================= Files 276 278 +2 Lines 41886 41978 +92 Branches 514 490 -24 ========================================= + Hits 2407 2409 +2 - Misses 39479 39569 +90 ``` | [Flag](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | `5.73% <0.97%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | Coverage Δ | | |---|---|---| | [.build/jisonTransformer.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=.build%2FjisonTransformer.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-LmJ1aWxkL2ppc29uVHJhbnNmb3JtZXIudHM=) | `0.00% <ø> (ø)` | | | [packages/mermaid-flowchart-elk/src/render-utils.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid-flowchart-elk%2Fsrc%2Frender-utils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC1mbG93Y2hhcnQtZWxrL3NyYy9yZW5kZXItdXRpbHMudHM=) | `0.00% <ø> (ø)` | | | [packages/mermaid-flowchart-elk/src/styles.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid-flowchart-elk%2Fsrc%2Fstyles.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC1mbG93Y2hhcnQtZWxrL3NyYy9zdHlsZXMudHM=) | `0.00% <ø> (ø)` | | | [packages/mermaid-zenuml/src/parser.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid-zenuml%2Fsrc%2Fparser.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC16ZW51bWwvc3JjL3BhcnNlci50cw==) | `0.00% <ø> (ø)` | | | [packages/mermaid/src/defaultConfig.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2FdefaultConfig.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGVmYXVsdENvbmZpZy50cw==) | `45.65% <100.00%> (ø)` | | | [...ackages/mermaid/src/diagrams/error/errorDiagram.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Ferror%2FerrorDiagram.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvZXJyb3IvZXJyb3JEaWFncmFtLnRz) | `0.00% <ø> (ø)` | | | [packages/mermaid/src/diagrams/gantt/ganttDb.js](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdiagrams%2Fgantt%2FganttDb.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGlhZ3JhbXMvZ2FudHQvZ2FudHREYi5qcw==) | `77.47% <100.00%> (ø)` | | | [packages/mermaid/src/config.ts](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fconfig.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvY29uZmlnLnRz) | `52.22% <50.00%> (ø)` | | | [packages/mermaid/src/dagre-wrapper/clusters.js](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdagre-wrapper%2Fclusters.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGFncmUtd3JhcHBlci9jbHVzdGVycy5qcw==) | `0.00% <0.00%> (ø)` | | | [...kages/mermaid/src/dagre-wrapper/intersect/index.js](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree&filepath=packages%2Fmermaid%2Fsrc%2Fdagre-wrapper%2Fintersect%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js#diff-cGFja2FnZXMvbWVybWFpZC9zcmMvZGFncmUtd3JhcHBlci9pbnRlcnNlY3QvaW5kZXguanM=) | `0.00% <0.00%> (ø)` | | | ... and [66 more](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/mermaid-js/mermaid/pull/5517/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mermaid-js)
sidharthv96 commented 1 month ago

Switching from develop to master so docs can be out immediately.

mermaid-bot[bot] commented 1 month ago

@GRASBOCK, Thank you for the contribution! You are now eligible for a year of Premium account on MermaidChart. Sign up with your GitHub account to activate.