Streamlining and enhancing diagram rendering across various diagram types

knsv commented 2 days ago

:bookmark_tabs: Summary

There is noticeable duplication in functionality among different diagram types. Several graph-based diagrams share common features in rendering, but these are implemented separately in each diagram type.

This PR introduces a Unified Layout Engine: Implement a singular layout engine for all graph-based diagrams.

Benefits:

Facilitates the introduction of new layout algorithms universally across all graph-based diagrams.
Enhances consistency in diagram layouts.
Standardizes interaction, styling, and class handling across diagrams.
Enables shape reusability between different diagram types.
Simplifies introduction of additional layout engines
New layout engines will work for all diagrams using this way of rendering

Resolves #5237

:straight_ruler: Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

:clipboard: Tasks

Make sure you

[x] :book: have read the contribution guidelines
[x] :computer: have added necessary unit/e2e tests.
[x] :notebook: have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
[x] :bookmark: targeted develop branch

netlify[bot] commented 2 days ago

Deploy Preview for mermaid-js ready!

Name	Link
Latest commit	444de0f133b003428c67bc6e97e6aeabe3cac7e8
Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/66805ecf9074a10008df0dce
Deploy Preview	https://deploy-preview-5604--mermaid-js.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

argos-ci[bot] commented 2 days ago

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	⚠️ Changes detected (Review)	322 changed, 4 added, 2 removed, 10 failures	Jun 29, 2024, 7:32 PM

mermaid-js / mermaid