search

mermaid-js / mermaid

Generation of diagrams like flowcharts or sequence diagrams from text in a similar manner as markdown
https://mermaid.js.org
MIT License
72.25k stars 6.58k forks source link

Upgrade to newer jison repo #873

Open knsv opened 5 years ago

knsv commented 5 years ago

The current version of jison used by mermaid is not maintained. There is a fork with some 1000 more commits under its belt. Letys switch to that version instead.

https://github.com/GerHobbelt/jison

github-actions[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you are still interested in it, and it is still relevant, you can comment or remove the label to revive it.

mearns commented 5 years ago

This might not be quite as trivial as I had assumed; just installing the new package, jison-gho, doesn't quite solve it as there seem to be some incompatibilities between this and the old package. I'm attempting to work my way through it, but not being familiar with jison, I don't know if I'll be able to resolve it.

mearns commented 5 years ago

Just wanted to leave a quick note that I haven't made any progress on this, and probably won't, in case anyone else is thinking about it.

klemmchr commented 5 years ago

I just had a look into that. This will contain a lot of breaking changes that could be problematic with features developed in other branches. I managed to resolve the first issues but the state diagram is creating this strange error

    TypeError: yyvstack[(yysp - 1)].push is not a function

      at Object.parser__PerformAction (src/diagrams/state/parser/stateDiagram.jison:865:28)
      at Parser.parse (src/diagrams/state/parser/stateDiagram.jison:1882:40)
      at Object.parse (src/diagrams/state/stateDiagram.spec.js:68:14)

Any idea what this could be @knsv? I have a rough idea but I had no deeper look into the state diagram language definition yet.

jgreywolf commented 3 years ago

The corresponding PR has been closed due to the extreme age of the changes.