Best practices on Syntax - Githubissues

mero12mero / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Best practices on Syntax #2

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago

Great work on closing your html elements this will make sure the html structure follows your logic. Also, great work on using other html attributes such as id and class names, both provide clarification on how to use and access your elements.

Also, cool use of html alt attributes, it helps identify the contents of image elements within your webpage for users who can’t view the image.

tommygebru commented 5 years ago

Minor typos and errors:

https://github.com/mero12mero/prj-rev-bwfs-dasmoto/blob/248d997a163f14217c58098bc60b19dab935fff8/Dasmoto's_Arts_and_Crafts/index.html#L8

Review Line 8 of your HTML, missing quotation marks " "
Incorrect use of the controls attribute, remove this from your image elements 👀

https://github.com/mero12mero/prj-rev-bwfs-dasmoto/blob/248d997a163f14217c58098bc60b19dab935fff8/Dasmoto's_Arts_and_Crafts/style.css#L5

Review line 5 of your CSS, align is not a property

https://github.com/mero12mero/prj-rev-bwfs-dasmoto/blob/248d997a163f14217c58098bc60b19dab935fff8/Dasmoto's_Arts_and_Crafts/style.css#L8

Review line 8 of your CSS, FA9A is not a hex color