search

meronex / meronex-icons

svg react icons of popular icon packs
Other
48 stars 2 forks source link

Fix icons fill #2

Closed eseQ closed 4 years ago

eseQ commented 4 years ago

From ugly icons image

to clear as the brilliant view clear as the brilliant

aogaili commented 4 years ago

Good catch, thanks.

But the issue with this fix is that it breaks font awesome which doesn't have a fill attribute defined. I think I'll add currentColor if not fill is defined otherwise we can use whatever the icon set specifies.

aogaili commented 4 years ago

Ok I think the last release should fix this issue, give it a try and let me know.

Thanks!

eseQ commented 4 years ago

@aliogaili Thanks, the issue has been resolved

aogaili commented 4 years ago

Cool, thanks again for the PR, will close this.