merpig / RubiksProgram

Program that simulates a rubiks cube
15 stars 8 forks source link

Incorrect evaluation of "Invalid Middle Configuration" #4

Closed lbarral closed 2 years ago

lbarral commented 3 years ago

A diagonal stripe pattern with the 4x4x4 cube, which is legal, always yields "Invalid Middle Configuration" in the 'solver' mode. Have a look at the following pictures: https://photos.app.goo.gl/fbWYoYoFFe4XQY2x8

Those are opposing corners of the cube (like rotating 180º in the view axis)

Attempting to create that pattern in the Solver mode is not permitted.

merpig commented 3 years ago

Interesting, I'll take a look and thank you for letting me know! Do you have an algorithm for that pattern I could use to test it out?

lbarral commented 3 years ago

I have added some screenshots from an android app called ASolver, with the reverse solve, to the same google photos album.

nvlashi commented 2 years ago

I'm also getting an "Invalid Middle Configuration" error on a valid 9x9 scramble.

Screen Shot 2022-01-06 at 12 33 30 PM Screen Shot 2022-01-06 at 12 32 26 PM
merpig commented 2 years ago

Been pretty busy recently, have had this on my list to fix and will get to it soon! I probably just need to simplify mapping stickers to the cube in the color picker.

merpig commented 2 years ago

I believe the issue has now been resolved. A size parameter that was expected when evaluating middle pieces wasn't being passed. Correctly added the parameter and the 4x4 case now runs as intended. I would test the 9x9 but the images don't include all sides. I believe they only shows 5 of the sides as the bottom left in the top image and the top right in the bottom image are the same side. If the fix solves both issues correctly for y'all I will close the issue.

nvlashi commented 2 years ago

Thanks.  I’ll give it a try and let you know. On Jan 25, 2022, 12:46 PM -0500, Alexandr (Sasha) Peters @.***>, wrote:

I believe the issue has now been resolved. A size parameter that was expected when evaluating middle pieces wasn't being passed. Correctly added the parameter and the 4x4 case now runs as intended. I would test the 9x9 but the images don't include all sides. I believe it only shows 5 of the side as the bottom left in the top image and the top right in the bottom image are the same side. If the fix solves both issues correctly for y'all I will close the issue. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

lbarral commented 2 years ago

I've tried the 4x4x4 using the https://merpig.github.io/RubiksProgram/ and it still ends up with the same message... is that version already containing the changes/fix? Or do I need to try somewhere else?

merpig commented 2 years ago

React uses webpack you may need to hard refresh, or close and reopen browser for the webpack to update with changes. Basically, the app is cached so it can be used offline. So, if you download the app since it's a PWA it won't need internet access to open and use.

update

** You'll know you have the update when there are arrows on the undo/redo buttons above the cube, I fixed that with the update as well