merryjs / photo-viewer

A photo picture viewer for React Native
https://merryjs.github.io/photo-viewer/interfaces/merryphotoviewporps.html
Apache License 2.0
269 stars 62 forks source link

Build failed with RN 0.62 on iOS #114

Open rmarquois opened 4 years ago

rmarquois commented 4 years ago

I tried to add your library in my project but I got this error when I run on iOS :

Undefined symbols for architecture x86_64: "_OBJCCLASS$_RCTImageLoader", referenced from: objc-class-ref in MerryPhotoView.o

Below is my package.json :

"@merryjs/photo-viewer": "3.1.4",
"react-native": "0.62.2",

I found a fix in the react-native-unimodules repository and it works !

I applied this changes in MerryPhotoView.m file.

RodolfoGS commented 4 years ago

I can't reproduce the bug, I tested and works perfect. Please create a reproducible demo if you can.

evilchis94 commented 3 years ago

It also happens to me:

"@merryjs/photo-viewer": "3.2.1", "react-native": "0.63.3"

NOTE: I'm using _use_frameworks!_