search

merryt / acquire

A digital version of this board game https://boardgamegeek.com/boardgame/5/acquire
0 stars 1 forks source link

BUG: change Gamestr to just game #16

Closed merryt closed 2 years ago

merryt commented 2 years ago

https://github.com/merryt/acquire/blob/main/public/GameList.js#L7-L8

This was originally a string that needed parsed, now it is an array so no parsing needed

KaylaKremer commented 2 years ago

Hello!

I'd like to work on this. Can you assign it to me?

merryt commented 2 years ago

Hey @KaylaKremer , I am SUPER new to any sort of open source stuff. You seem WAY more experienced in it then I am.

Do I give you collaborator access to this project? do you make a fork and make a PR from that fork?

Thank you for 1️⃣ helping me learn more about open source stuff and 2️⃣ all your help and interest in this project!

KaylaKremer commented 2 years ago

Hey @merryt !

Nope, you don't have to give me collab access. I'll just fork it and make a PR from the fork!

Also, if you want to attract more help, I recommend putting the "hacktoberfest" label to your project/issues so that it shows up when people search that hashtag!

Here's some more info specifically for maintainers here: https://hacktoberfest.digitalocean.com/resources/maintainers

And in case you don't know what Hacktoberfest is, it's a month-long celebration of open source! So that's why I'm finding open source projects like yours and helping out!

Hope that helps!

merryt commented 2 years ago

Thank you for the good info @KaylaKremer !

With only a few more days in the month I might pass on this year, but try to get into next years hacktoberfest!

I am also JUST getting this project off the ground and still feeling out the organization structure of this project.

Thanks again for all your help with this issue! Your PR looked great merged it into main!

Cheers, Tyler

KaylaKremer commented 2 years ago

Np!

And I definitely understand! Do you mind labeling my PR though as "hacktoberfest-accepted" so that it counts towards my total? I just realized it's not showing up because of this.

And if you need any other help for the project, let me know!

merryt commented 2 years ago

Totally! Does this work for you? (How I tagged the PR and issue)

If you see any other issues you want to tackle let me know! I can also cut off some small starter blocks of work if you want more familiarity with the code base. Just let me know how much you want to be involved!