mersinvald / aquamarine

Inline diagrams for rustdoc with mermaid.js
MIT License
487 stars 25 forks source link

Minimal compiler version is wrong #16

Closed jmg-duarte closed 2 years ago

jmg-duarte commented 3 years ago

Running with Rust 1.38

jmgd@kronos ~/D/m/r/typestate-rs (main)> cargo +1.38 build
   Compiling proc-macro2 v1.0.26
   Compiling unicode-xid v0.2.2
   Compiling syn v1.0.72
   Compiling version_check v0.9.3
   Compiling fnv v1.0.7
   Compiling strsim v0.10.0
   Compiling ident_case v1.0.1
   Compiling either v1.6.1
   Compiling itertools v0.9.0
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
   Compiling quote v1.0.9
   Compiling darling_core v0.13.0
   Compiling aquamarine v0.1.9
error: cannot find macro `matches!` in this scope
  --> /home/jmgd/.cargo/registry/src/github.com-1ecc6299db9ec823/aquamarine-0.1.9/src/attrs.rs:43:9
   |
43 |         matches!(self, Attr::DiagramEnd(_))
   |         ^^^^^^^

error: cannot find macro `matches!` in this scope
   --> /home/jmgd/.cargo/registry/src/github.com-1ecc6299db9ec823/aquamarine-0.1.9/src/attrs.rs:168:9
    |
168 |         matches!(self, Location::InsideDiagram)
    |         ^^^^^^^

error: cannot find macro `matches!` in this scope
   --> /home/jmgd/.cargo/registry/src/github.com-1ecc6299db9ec823/aquamarine-0.1.9/src/attrs.rs:138:28
    |
138 |                         if matches!(attr, Attr::DiagramStart(_)) {
    |                            ^^^^^^^

error: aborting due to 3 previous errors

error: Could not compile `aquamarine`.
warning: build failed, waiting for other jobs to finish...
error: build failed
jmg-duarte commented 3 years ago

1.41 doesn't work either. Same error.

1.42 does work fine!

mersinvald commented 2 years ago

I probably fixed that and did not close the issue. Current MSRV is correct:

aquamarine|master ⇒ cargo msrv --ignore-lockfile --max 1.31.1
Fetching index
Determining the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check --all
   Finished The MSRV is: 1.31.1   
aquamarine|master ⇒ cargo +1.31.1 check --all
   Compiling aquamarine v0.1.10 (/home/mkl/dev/rust/aquamarine)
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s