mersinvald / aquamarine

Inline diagrams for rustdoc with mermaid.js
MIT License
487 stars 25 forks source link

Review port to mermaid v10 #35

Closed frehberg closed 1 year ago

frehberg commented 1 year ago

To test the port, change the dependency in Cargo.toml to

[dependencies]
aquamarine = { git = "https://github.com/frehberg/aquamarine.git", branch = "35_port_mermaid_v10" }
frehberg commented 1 year ago

Please comment the the Pull Request https://github.com/mersinvald/aquamarine/pull/36

frehberg commented 1 year ago

Changes of pull request #36

image

frehberg commented 1 year ago

To test the port, change the dependency in Cargo.toml to

[dependencies]
aquamarine = { git = "https://github.com/frehberg/aquamarine.git", branch = "35_port_mermaid_v10" }
mersinvald commented 1 year ago

@frehberg I'm on it. To streamline the process from now, I'm going to add you as a maintainer too, as I don't get much time to work on this project at the moment.

frehberg commented 1 year ago

cool :)

Mike Lubinets @.***> schrieb am Mo., 17. Apr. 2023, 10:53:

@frehberg https://github.com/frehberg I'm on it. To streamline the process from now, I'm going to add you as a maintainer too, as I don't get much time to work on this project at the moment.

— Reply to this email directly, view it on GitHub https://github.com/mersinvald/aquamarine/issues/35#issuecomment-1510954913, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB265RHRDCJH2Q5GYWIPQ3XBUAJPANCNFSM6AAAAAAVUPHKHA . You are receiving this because you were mentioned.Message ID: @.***>

frehberg commented 1 year ago

cool :)

just, AFAICS, I cannot edit tickets or merge branches yet

Mike Lubinets @.***> schrieb am Mo., 17. Apr. 2023, 11:02:

Closed #35 https://github.com/mersinvald/aquamarine/issues/35 as completed.

— Reply to this email directly, view it on GitHub https://github.com/mersinvald/aquamarine/issues/35#event-9021780372, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB265QJH6OMOGSXUWXO2KLXBUBJPANCNFSM6AAAAAAVUPHKHA . You are receiving this because you were mentioned.Message ID: @.***>

mersinvald commented 1 year ago

@frehberg says you didn't accept invite yet