search

mersinvald / aquamarine

Inline diagrams for rustdoc with mermaid.js
MIT License
487 stars 25 forks source link

fix: prepend CARGO_MANIFEST_DIR to include path #47

Closed Rjected closed 7 months ago

Rjected commented 7 months ago

Some of our users have been having problems with our usage of include_mmd!, see investigation here: https://github.com/paradigmxyz/reth/issues/6030#issuecomment-1888290062

The current implementation of include_mmd seems to introduce some ambiguity, at least between:

Prepending CARGO_MANIFEST_DIR would break our existing usage of include_mmd! but allows the location for mermaid diagrams to be consistent across our project, and projects that depend on us.

mersinvald commented 7 months ago

@Rjected thanks for catching that. I'll increment the major and yank the current version.