search

merthidayetoglu / CommBench

A Micro-benchmarking Tool for HPC Networks
Apache License 2.0
15 stars 6 forks source link

CAP_NCCL commented out in commbench.h #4

Open simongdg opened 3 months ago

simongdg commented 3 months ago

https://github.com/merthidayetoglu/CommBench/blob/master/commbench.h

Line 40 to 46 what is the point of commenting out the #define CAP_NCCL and others.

I have to manually uncomment it out to make PORT_HIP work

@merthidayetoglu 


#if defined PORT_CUDA || defined PORT_HIP
// #define CAP_NCCL
#endif
#ifdef PORT_ONEAPI
// #define CAP_ZE
// #define CAP_ONECCL
#endif
merthidayetoglu commented 3 months ago

Yes, some systems have CUDA but not necessarily NCCL. You can do:

#define PORT_CUDA
#define CAP_NCCL
#include "commbench.h"

to enable NCCL.

In AMD case:

#define PORT_HIP
#define CAP_NCCL
#include "commbench.h"