mervanamerbabe / DasmotosProject

CodeAcademy Intensive: Dasmotos Project (Build Websites from Scratch) Unit 2
0 stars 0 forks source link

CSS #2

Open tbergen1 opened 5 years ago

tbergen1 commented 5 years ago

You did well with your CSS. Your formatting was good and you did well to choose descriptive selector names. I would recommend you leverage inheritance to "DRY" up your code. You are currently almost doing that by applying a shared style like font-family to the top level html selector. This allows you to not have to apply that same style to any of the children.

mervanamerbabe commented 5 years ago

Thank you so much for your constructive feedback, I really appreciate that. I changed the formatting like that at the last minute since I couldn't get the colors to show up on the backgrounds for some reason until I changed it to be super repetitive. It was likely just a simple rogue character however that was creating the problem. Not making excuses, agreeing that it's better dry it up. I am totally new to this and really enjoying the learning process. Thank you again!