search

mesalock-linux / mesabox

A collection of core system utilities written in Rust for Unix-like systems (and now Windows)
BSD 3-Clause "New" or "Revised" License
137 stars 19 forks source link

loginutils/getty issues #2

Open Arcterus opened 6 years ago

Arcterus commented 6 years ago

Firstly, getty shouldn't just panic on failure (it should instead return Results like the other utilities). Because of how getty affects the state of the system, I think the execve() call may be alright though.

getty should not be hard-coded to call /bin/ion. It should instead take an argument specifying what TTY to take control of and what program to start on said TTY (the current values can serve as defaults, however). We may want to implement gettytab or something similar as well.

mssun commented 6 years ago

True. Please ignore my previous simple implementation. We need a decent getty.

Arcterus commented 6 years ago

Yeah, I'm just writing down some notes. The current version is a good enough jumping off point though.