search

mesalock-linux / mesabox

A collection of core system utilities written in Rust for Unix-like systems (and now Windows)
BSD 3-Clause "New" or "Revised" License
137 stars 19 forks source link

Add partial implementation of mount #46

Open lizhuohua opened 6 years ago

lizhuohua commented 6 years ago

Most LSB features are supported, except -v (print diagnostic messages), -n (mount without writing in /etc/mtab), and -s (ignore mount options not supported by a file system type). Also, user mountable devices are not supported yet.

Some tests need root privilege, they are marked as #[ignore]. To run them, use the following command: sudo cargo test root_test_mount -- --ignored --test-threads 1. (We have to disable parallel tests, because the tests will mount the same device.)

codecov[bot] commented 6 years ago

Codecov Report

Merging #46 into master will decrease coverage by 0.93%. The diff coverage is 2.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   19.95%   19.01%   -0.94%     
==========================================
  Files          46       47       +1     
  Lines        4680     5027     +347     
  Branches     1081     1183     +102     
==========================================
+ Hits          934      956      +22     
- Misses       3355     3663     +308     
- Partials      391      408      +17
Impacted Files Coverage Δ
libmesabox/src/lib.rs 59.01% <ø> (ø) :arrow_up:
libmesabox/src/lsb/mount/mod.rs 2.28% <2.28%> (ø)
libmesabox/src/posix/cat.rs 35.01% <0%> (-4.75%) :arrow_down:
libmesabox/src/gnu/arch.rs 71.42% <0%> (-3.58%) :arrow_down:
libmesabox/src/gnu/base32/common.rs 56.25% <0%> (ø) :arrow_up:
libmesabox/src/posix/head.rs 46.82% <0%> (-0.34%) :arrow_down:
libmesabox/src/posix/echo.rs 51.25% <0%> (+1.25%) :arrow_up:
libmesabox/src/posix/sh/ast.rs 27.52% <0%> (+0.07%) :arrow_up:
libmesabox/src/posix/sh/mod.rs 31.53% <0%> (+0.24%) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17de43b...2f51827. Read the comment docs.

mssun commented 6 years ago

Can you refactor your code according to the dummy utility here? https://github.com/mesalock-linux/mesabox/pull/47