mesalock-linux / mesabox

A collection of core system utilities written in Rust for Unix-like systems (and now Windows)
BSD 3-Clause "New" or "Revised" License
137 stars 19 forks source link

Support code coverage using llvm-gcov (fix #6) #7

Closed mssun closed 6 years ago

mssun commented 6 years ago
mssun commented 6 years ago

continuous-integration/drone/pr — the build failed

This should be fixed in CI. By default, the CI will not provide secret to for PR event.

Arcterus commented 6 years ago

This seems at least better than what we have right now as it does work, but I'm not so sure about the accuracy. On Coveralls, it noted that src/head had 70.2% coverage, but then the only file in src/head is src/head/mod.rs, which supposedly has 38.1% coverage? If you look at the reported coverage for the source code, it always (or at least almost always) differs from the coverage for the directory.

I think technically the reported coverage for the source code itself is more accurate, as it's mentioning missed branches for parsing failures and such, but I'm not sure why the directory coverage differs?

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ea2628e). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   27.34%           
=========================================
  Files             ?       23           
  Lines             ?     2370           
  Branches          ?      519           
=========================================
  Hits              ?      648           
  Misses            ?     1572           
  Partials          ?      150

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea2628e...af099bc. Read the comment docs.