search

mescon / Muximux

A lightweight way to manage your HTPC
GNU General Public License v2.0
1.14k stars 83 forks source link

Add a Radarr icon #119

Open fryfrog opened 7 years ago

fryfrog commented 7 years ago

It would be great to have a nice little icon for Radarr, I found this directory of logos on their github.

https://github.com/Radarr/Radarr/tree/develop/Logo

NathanTheGr8 commented 7 years ago

I am trying to add the icon to the project but I am a bit confused. Where are the custom font awesome icons kept? I assume we will need the svg.

mescon commented 7 years ago

https://github.com/mescon/Muximux/blob/master/css/font-muximux.css

NathanTheGr8 commented 7 years ago

Ok, so I am a bit lost on how to do this. I see there are four custom font files, muximuxfonts in TTF, SVG, eof, and wofff.

So my first question would be would I need to add a radarr icon to each font?

My second question would be how in gods name do I open and edit fonts? I tried opening the SVG one in Adobe Illustrator, and it just looked blank. I then downloaded FontForge and tried to open the TTF in it. It wasn't blank, but I didn't see where the icons were at. So what program do you use to edit these font files? I am on a mac, but I have access to Windows and Linux machines.

d8ahazard commented 7 years ago

https://icomoon.io/app/#/select

On Mon, May 29, 2017 at 9:36 PM, Nathan notifications@github.com wrote:

Ok, so I am a bit lost on how to do this. I see there are four custom font files, muximuxfonts in TTF, SVG, eof, and wofff.

So my first question would be would I need to add a radarr icon to each font?

My second question would be how in gods name do I open and edit fonts? I tried opening the SVG one in Adobe Illustrator, and it just looked blank. I then downloaded FontForge https://github.com/fontforge/fontforge/releases and tried to open the TTF in it. It wasn't blank, but I didn't see where the icons were at. So what program do you use to edit these font files? I am on a mac, but I have access to Windows and Linux machines.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mescon/Muximux/issues/119#issuecomment-304760701, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjuNE18yKIVhPxHBzoMg_EHe13-LUR9ks5r-4CYgaJpZM4L-Z0Z .

morpheus65535 commented 7 years ago

Any news on adding the Radarr icon?

d8ahazard commented 7 years ago

It's still lurking in the back of my brain from waaaay back when. Just because I like to talk about myself, here's a rough outline of what I'm intending on doing now that I'm working on MM again:

  1. Fix the exploit that allowed effing up the config file, and other things that are maybe a bit insecure. This initial fix was pushed to the develop branch yesterday.

  2. Update ALL of the dependency libs. Jquery, jquery UI, bootstrap, etc. I started this yesterday, but changing bootstrap breaks a lot of things, so this will take a few days.

  3. Sanitize, clean, etc. I've learned a lot more about PHP since the last update, so looking at what I did in here since then makes me cringe a bit. We can do a LOT better, and this can be a LOT prettier, faster, cooler. ;)

  4. Add other app Icons that were missed initially - including Radarr.

  5. Make it a proper "Progressive Web App" for google. Basically, you can install MM like an Android app, it'll use a service worker to cache the majority of the page stuff so it loads super-fast on mobile.

  6. Implement other feature requests as I'm able.

Unfortunately, I woke up this morning, came to work, and my NAS seems to have gone belly-up in the night, meaning I need to race home on my lunch break and reboot it, hope it comes back to life...else I may sob uncontrollably for a while and then stamp my feet just for good measure. :P

On Tue, Aug 15, 2017 at 8:43 AM, Louis Vézina notifications@github.com wrote:

Any news on adding the Radarr icon?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mescon/Muximux/issues/119#issuecomment-322469236, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjuNATmDHviy_d3AP737G3IS2Y5JQMpks5sYaBzgaJpZM4L-Z0Z .

morpheus65535 commented 7 years ago

So we could expect the new icons when you get back from lunch, right? ;-)

Seriously, I totally understand. Nice work so far and thank you for your time!

d8ahazard commented 6 years ago

@morpheus65535 - Clearly, not back from lunch. :P

However, making tons of progress. All the dependencies have been overhauled. TONS of dead weight is gone. Many many many fixes and tweaks have happened in nearly every facet of the app. There's a new icon picker with a search feature and categories. The settings UI has been fixed and tweaked and fixed again. PWA features are well on their way.

Had a chance to look at the graphics for the radarr icon, and yeah, it should be nice and easy now to add this to the list of icons. :D

morpheus65535 commented 6 years ago

Great news! Thank you very much :-)

wtf911 commented 6 years ago

Not to distract from Radarr but an icon for qBittorrent would be nice as well. :)

hitnrun30 commented 6 years ago

I would just like qBittorent to work, have you been able to open the web ui through MM

wtf911 commented 6 years ago

If you enable the web iu in qbittorrent which I'm hoping you've already done... And if muximux and qbittorrent are running on the same host then it already works. The case where it doesn't work is when qbittorrent is run on a different host. Right now it blocks being called through an iframe from a different host.

hitnrun30 commented 6 years ago

both are on the same machine, no matter what i do, it just has a black screen, all my other apps work including SABnzbd and Sonarr and Radarr... just qbittorrent

wtf911 commented 6 years ago

https://github.com/qbittorrent/qBittorrent/issues/7370#issuecomment-334854973

I actually opened that for this issue. But umm in your case maybe one is using localhost and the other the IP? Try both ways and make sure both match muximux and qbittorrent.

hitnrun30 commented 6 years ago

tried it, if I put the url in the address, no problem, MM, wont work., i was told that there is a plugin that may work, would you know which one for chrome?

betamax2021 commented 5 years ago

Addressed in my fork. https://github.com/betamax2021/Muximux2/commit/83fb3f77a71c9af855e51656fbfeba5e2f994f54

Morphy99 commented 3 years ago

@morpheus65535 - Clearly, not back from lunch. :P

However, making tons of progress. All the dependencies have been overhauled. TONS of dead weight is gone. Many many many fixes and tweaks have happened in nearly every facet of the app. There's a new icon picker with a search feature and categories. The settings UI has been fixed and tweaked and fixed again. PWA features are well on their way.

Had a chance to look at the graphics for the radarr icon, and yeah, it should be nice and easy now to add this to the list of icons. :D

Hi guys/gals I've just been looking at adding some icons myself and after a few hours of trial and error I've finally figured it out (I think!). Well, it works just about on my local copy of muximux at least. I'd like to merge my icons into master but I just need to clarify I'm doing things right and a couple of discrepancies with the icons.

First off the number of icons showing in my untouched instance of muximux is 2618. When I try to add the svg files from config\www\muximux\fonts to icomoon I get 2889. I've added: muximuxfonts.svg (2024) glyphicons-halflings-regular.svg (605) fontawesome-webfont.svg (260)

No combination of those add up to 2618 so I'm confused why only 2618 are showing. After adding my icons I noticed one of them isn't being picked up for some reason so I'm not sure if this has something to do with the number discrepancies. I will investigate that further but any tips are appreciated! Here is what I'm doing to add the:

  1. Upload muximuxfonts.svg file to icomoon.
  2. Add additional custom icon svg's to muximuxfont set.
  3. Go to Font tab and wait for it to load
  4. Download zip and extract
  5. Copy the four files in fonts dir to muximux data dir: config\www\muximux\fonts and overwriting existing
  6. Rename style.css in the root of downloaded font zip folder to font-muximux.css and copy over to css dir in muximux data folder.
  7. Reload muximux page and voila icons are working! When I worked through this again the icon that was disappearing is now showing. It may be something to do with caps in the name, that's the only thing I can recall changing.

As you can tell I'm no expert in this but I think it's correct. If I can get the discrepancies sorted I don't mind adding mine and other icons to the master.

d8ahazard commented 3 years ago

FWIW, the original font set was created using IcoMoon, which looks to still be in existence and working as it was when I originally created it.

https://icomoon.io/app

I think you can just drop the existing set into it and add the new icon(s). ;)

d8ahazard commented 3 years ago

Dur, sorry, can't read this morning. Let me try that again...

Yep, I did it with IcoMoon. Your instructions look correct. :P

On Sat, Jan 30, 2021 at 10:05 AM Ben K. d8ahazard@gmail.com wrote:

FWIW, the original font set was created using IcoMoon, which looks to still be in existence and working as it was when I originally created it.

https://icomoon.io/app

I think you can just drop the existing set into it and add the new icon(s). ;)

Morphy99 commented 3 years ago

Yea that's what I did and the numbers don't tally for some reason. Can someone else verify how many icons show up on theirs?

So I added 7 icons to the muximux set and added the other two: glyphicons-halflings-regular.svg (605) fontawesome-webfont.svg (260) And I now get 2897 which is correct seeing as one is blank. It's more than the default muximux qty though so maybe I fixed something?!

I think maybe I'm doing it wrong including the extra svg's above with the icomoon download as it adds them all to muximux.svg. How do I include those extra ones and keep the svg files separate? I'm guessing I have to download each set separately from icomoon then hack together the font-muximux.css so it includes them all?

d8ahazard commented 3 years ago

I could be mistaken, but I thought the original "big" iconset already contained fontawesome and glyphicons via icoMoon, although I'm sure they've been updated since then.

Might be easier to start from scratch - add all of the sets icomoon has available, add in the few "extra" icons that were created custom, and export.

On Sat, Jan 30, 2021 at 10:30 AM Morphy99 notifications@github.com wrote:

Yea that's what I did and the numbers don't tally for some reason. Can someone else verify how many icons show up on theirs?

So I added 7 icons to the muximux set and added the other two: glyphicons-halflings-regular.svg (605) fontawesome-webfont.svg (260) And I now get 2897 which is correct seeing as one is blank. It's more than the default muximux qty though so maybe I fixed something?!

I think maybe I'm doing it wrong including the extra svg's above with the icomoon download as it adds them all to muximux.svg. How do I include those extra ones and keep the svg files separate? I'm guessing I have to download each set separately from icomoon then hack together the font-muximux.css so it includes them all?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mescon/Muximux/issues/119#issuecomment-770239868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMO4NFAALQCNIUUESCPK5LS4QXZ5ANCNFSM4C7ZTUMQ .

Morphy99 commented 3 years ago

Ok, I can do that. So once I add them all to muximuxfonts we don't need these files then: fontawesome-webfont. glyphicons-halflings-regular.

d8ahazard commented 3 years ago

Exactly.

On Sat, Jan 30, 2021, 11:34 AM Morphy99 notifications@github.com wrote:

Ok, I can do that. So once I add them all to muximuxfonts we don't need these files then: fontawesome-webfont. glyphicons-halflings-regular.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mescon/Muximux/issues/119#issuecomment-770248582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMO4NAZIITCIEOQDK76L5DS4Q7KDANCNFSM4C7ZTUMQ .

Morphy99 commented 3 years ago

So I've noticed that muximuxfonts contains icons from other sets on icomoon and filtering out the duplicates is quite laborious. I've combined these sets together:

muximuxfonts (uploaded from project) Font Awesome Material Icons Brands IcoMoon Free

There were a few other sets in the free libraries but these were the biggest and it's already on 5555 icons and I don't want to go too overboard?

I have then downloaded the svg's individually to see if file filters can help. I deleted all filenames ending in 1 which I think icomoon assigns with a duplicate file name, but even now I still have quite a few duplicates which I can see visually. I'm going through removing those manually now.

If anyone has any requests for additional icons let me know and I'll add them.

mescon commented 3 years ago

@Morphy99 if you could, I know there are a lot of people who would be happy to see these icons: Emby, Pi-Hole, Portainer, OpenMediaVault (OMV), Jellyfin, Lidarr, Proxmox, Bazarr.

Thanks man!