search

mescon / Muximux

A lightweight way to manage your HTPC
GNU General Public License v2.0
1.14k stars 83 forks source link

fix two safari UI issues #200

Closed a-chaudhari closed 3 years ago

a-chaudhari commented 3 years ago

this fixes two UI issues under safari. it fixes the height of the menubar and it fixes the menubar item text being cut off.

125

151

Screen Shot 2021-01-24 at 12 59 12 PM

fixing the menubar height appears to have no issues on other browsers.

Capture

however the text cutoff is more of a workaround, it causes a little bit of overlap between buttons on mouseover, but I think it's an improvment compared to the current state under safari.

Screen Shot 2021-01-24 at 1 00 13 PM
mescon commented 3 years ago

Does it cause overlaps in other browsers? In your first examples, what text is actually cut off? Can't see it myself...

a-chaudhari commented 3 years ago

the first image in #125 is a good example of the menu bar issue on safari devices.

you'll see the text is cut off and the menu bar is too tall

edit: and yes it causes overlap on all browsers

mescon commented 3 years ago

are we looking at the same images? the ones you linked to above does not have any text cut off as far as I can see... where?

EDIT: Ah, the image in in #125 ... my bad. Could you please drill down into this as to not cause overlap? Seems bad to introduce new bugs to fix old ones. Thanks!

a-chaudhari commented 3 years ago

ok I have a better way that causes no overlap.

Screen Shot 2021-01-24 at 3 44 27 PM
mescon commented 3 years ago

Awesome, merged! Feel free to fix any other bugs or issues you find - happy to merge :)