search

mescon / Muximux

A lightweight way to manage your HTPC
GNU General Public License v2.0
1.14k stars 82 forks source link

[Feature request] Add option in landing page to open link in new tab #47

Closed maxime-roy closed 8 years ago

maxime-roy commented 8 years ago

Hi!

I've just started to use Muximux and it's awesome!

However, I have a small issue with it. When I use Muximux to open an application that already uses multiple iframes (in this case Subsonic), all the javascripts used to do interactions with the application aren't working. When I open the same application but without Muximux, everything is working properly.

In order to bypass this issue but still have the application listed in Muximux, I think it could be great to add an option in landing page to open link in new tab. I know that we could just right-click on the "launch x app" button and then click on open in new tab but it could be convenient don't you think?

If you need more clarification don't hesitate to let me know!

Kind regards,

mescon commented 8 years ago

Hi @maxime-roy. Though I appreciate your well written feature request, I don't agree with implementing this inside of Muximux itself, basically because I see this as redundant. You're free to bookmark applications directly, and right now I do not have plans to implement this feature.

Things might change if I happen to be up some night having nothing better to do, but until then I'm closing this issue.

I'd be happy to review a pull request if somebody wants to implement this though.

Siebes commented 8 years ago

As a work around for the lazy do this (works for landing pages) http://urlyouwant.com\" target=\"_blank\" title=\"Title you want\"><br \"

jedimstr commented 7 years ago

@Siebes - the work around doesn't seem to work. The escape \ get's dropped on save.

Siebes commented 7 years ago

@jedimstr try editing the settings.ini.php file directly - this is just a hack e.g.

[JIRA]
name = "JIRA"
url = "http://jira/secure/Dashboard.jspa\" target=\"_blank\" title=\"Launch JIRA!\"><br \""
icon = "fa-tasks"
enabled = "true"
default = "false"
landingpage = "true"
dd = "false"
scale = 0.1
movanet commented 7 years ago

I've tried it but the workaround doesn't work. I need it because ubooquity refuse to download pdf when used inside muximux. Probably because of my chrome setting which choose to view pdf instead of downloading it.