search

mesg-foundation / engine

Build apps or autonomous workflows with reusable, shareable integrations connecting any service, app, blockchain or decentralized network.
https://mesg.com/
Apache License 2.0
130 stars 13 forks source link

fix runner e2e that block the tests on error #1809

Closed NicolasMahe closed 4 years ago

NicolasMahe commented 4 years ago

fix runner e2e that block the tests on error

to remember: when a require. function "fail" it will not run other t.Run functions but will run the remaining code in the parent function.

antho1404 commented 4 years ago

Not sure I understand this fix? I don't see any problem merging that but not sure what it actually fix

NicolasMahe commented 4 years ago

Not sure I understand this fix? I don't see any problem merging that but not sure what it actually fix

behavior in the dev version: if the previous test fails (https://github.com/mesg-foundation/engine/pull/1809/files#diff-b45f199c25c42d4525f0000d48498a06R68-R70) then the stream.Recv() blocks forever and the e2e tests never fail properly.

behavior in this branch version: if the previous test fails, then the test following test (that should block with stream.Recv()) is simply never skipped and the e2e tests fails properly.