search

mesg-foundation / engine

Build apps or autonomous workflows with reusable, shareable integrations connecting any service, app, blockchain or decentralized network.
https://mesg.com/
Apache License 2.0
130 stars 13 forks source link

Rename "command" property in mesg.yml #570

Closed NicolasMahe closed 5 years ago

NicolasMahe commented 5 years ago

The property command in the mesg.yml should be renamed to arguments because it is send to Docker API in the Args:

https://github.com/mesg-foundation/core/blob/3f76f8b5a5115035033adecd580a6ba648d8a121/service/start.go#L82

ilgooz commented 5 years ago

I think command is a better name because we're actually setting what command should be run on start of service's container. args word does not explain enough about the actual behavior.

NicolasMahe commented 5 years ago

Actually it’s not the command we want to run but the arguments that will be pass to the command. Docker already offer both, command and args options. I don’t know why, but the implementation mixed it up. We could actually offer both command and args parameter in the mesg.yml.