search

mesg-foundation / engine

Build apps or autonomous workflows with reusable, shareable integrations connecting any service, app, blockchain or decentralized network.
https://mesg.com/
Apache License 2.0
130 stars 13 forks source link

Use build functions from docker packages #921

Closed NicolasMahe closed 4 years ago

NicolasMahe commented 5 years ago

Currently, the package container is redefining some function that are already defined in docker packages. We should remove them and use as much as possible function from docker packages. Eg: https://github.com/mesg-foundation/core/blob/dev/container/build.go#L48-L58 should be replaced by github.com/docker/cli/cli/command/image/build.ReadDockerignore

See https://github.com/mesg-foundation/core/blob/dev/commands/provider/service_deployer.go#L129 as example

NicolasMahe commented 5 years ago

why this one has been closed?

NicolasMahe commented 4 years ago

Closing because https://github.com/mesg-foundation/engine/pull/1400 improved enough the function used.