Closed NicolasMahe closed 5 years ago
In PR https://github.com/mesg-foundation/core/pull/904, the package manager has been introduced to manage the logic between service and container.
Following the logic of moving everything not related to the service's data outside the service package (https://github.com/mesg-foundation/core/issues/958), the service's log struct should also moved to the package manager.
Service log struct: https://github.com/mesg-foundation/core/blob/dev/service/service.go#L88-L92
The service package should have only logic about the service's data and nothing more.
Basically, the file manager.go should only return struct define in its own package.
manager.go
Please tell if you are agree to move namespace to manager or leave it like this.
same as https://github.com/mesg-foundation/core/issues/958#issuecomment-493016903
ilgooz
commented
5 years ago
In PR https://github.com/mesg-foundation/core/pull/904, the package manager has been introduced to manage the logic between service and container.
Following the logic of moving everything not related to the service's data outside the service package (https://github.com/mesg-foundation/core/issues/958), the service's log struct should also moved to the package manager.
Service log struct: https://github.com/mesg-foundation/core/blob/dev/service/service.go#L88-L92
The service package should have only logic about the service's data and nothing more.
Basically, the file
manager.goshould only return struct define in its own package.Please tell if you are agree to move namespace to manager or leave it like this.