search

mesg-foundation / js-sdk

Javascript mono-repo with all the tools to interact with MESG
https://mesg.com
4 stars 4 forks source link

Wallet cli based on id #128

Closed antho1404 closed 4 years ago

antho1404 commented 5 years ago

The mesg-core wallet list displays an ID but this ID seems useless or there is a bug in the export task. I would expect if there is an ID to be able to use the ID for the export and delete functions but I have an error.

Either we have ID and we support it in these functions or we don't have ID.

I would vote for no ID

NicolasMahe commented 5 years ago

The number you mean? It's only there for UX.

antho1404 commented 5 years ago

it's called ID in the list

ID    ACCOUNT
1     0xfde8b69e8eee1c116bc678602a752c909189f955

And also it doesn't serve the UX because we cannot reuse it so it's the opposite

NicolasMahe commented 5 years ago

In my case it helps me choosing which account to use. But yes, ID is a bad word for this. Maybe just #?