Added env, repeated and nested docs

mesg-foundation / js-sdk

Javascript mono-repo with all the tools to interact with MESG

https://mesg.com

4 stars 4 forks source link

Closed uivlis closed 4 years ago

uivlis commented 4 years ago

Let me know if your require any other modifications.

antho1404 commented 4 years ago

Hi @uivlis, thanks for the work, could you fix a few things.

Put the env variables before events and tasks
Display the env as a list
ENV1=xxx
ENV2=yyy
Embed the "repeated" in the type. So if it's a repeated String then display String[]

If you want a good example to test that you can use the following service

git clone https://github.com/mesg-foundation/service-plasma-omisego-watcher
cd service-plasma-omisego-watcher
./bin/run service:doc

uivlis commented 4 years ago

Hope it's better now.

antho1404 commented 4 years ago

I did a few suggestions in the code

uivlis commented 4 years ago

Thanks for the suggestions! Ready to merge?

uivlis commented 4 years ago

In the last commit I also took care of #15 (and applied to that respective bounty), hoping my solution is fine.

antho1404 commented 4 years ago

Hi, could you please do that in another pull request. I would like to keep each pull request organized.

uivlis commented 4 years ago

Should be good to go now, I will submit work for #15 in a new branch.