Command core start should wait for all system service to be deployed

mesg-foundation / js-sdk

Javascript mono-repo with all the tools to interact with MESG

https://mesg.com

4 stars 4 forks source link

Command core start should wait for all system service to be deployed #20

Closed NicolasMahe closed 4 years ago

NicolasMahe commented 5 years ago

The command core start should wait for all system service to be deployed and for the gRPC server to be up and running.

➜  ./mesg-core start
✔ Core started
➜  ./mesg-core logs
time="2019-04-26T07:11:15Z" level=info msg="Deploying service \"ethwallet\" from \"http://ipfs.app.mesg.com:8080/ipfs/QmcZXaVaZbzQ8nPfohwmjVdoWvut3HAtDHyv2cScwxdcnE\""

antho1404 commented 5 years ago

Or we could simply make the start command with a detach mode (the one implemented actually). When we don't have the option detach then we have the same behavior than the dev command or the dev-core. We start, show the logs until user exits and then stop the core.

ilgooz commented 5 years ago

@NicolasMahe let's move this to cli's repo

ilgooz commented 5 years ago

This can be solved by implementing https://github.com/mesg-foundation/engine/issues/1159#issuecomment-509395452 on Engine. But same logic can be implemented in here, cli as well. I think I prefer to have this on Engine's Instance.Create() but maybe optionally. For ex: Instance.Create(waitForReady bool)

antho1404 commented 4 years ago

the daemon:start now waits for the API to be ready, also, we don't have any system service anymore