search

mesg-foundation / js-sdk

Javascript mono-repo with all the tools to interact with MESG
https://mesg.com
4 stars 4 forks source link

Support multi runners for services #235

Closed antho1404 closed 4 years ago

antho1404 commented 4 years ago

fix #232

We can now run multiple instances of the same service without having any conflicts in the container created

NicolasMahe commented 4 years ago

Not related to this PR but can be fixed here: The alias of the service on the engine's network seems wrong: https://github.com/mesg-foundation/js-sdk/blob/bcd6a6cede969a471fc105a02a29d9baa827b263/packages/runner/src/providers/container/index.ts#L102 The alias should simply not be set.

The variable serviceEndpoint is really confusing. It should be engineEndpoint and directly include the port: https://github.com/mesg-foundation/js-sdk/blob/bcd6a6cede969a471fc105a02a29d9baa827b263/packages/runner/src/providers/container/index.ts#L81

antho1404 commented 4 years ago

good catch, fixed