Lib is returning an error for task not implemented

mesg-foundation / js-sdk

Javascript mono-repo with all the tools to interact with MESG

https://mesg.com

4 stars 4 forks source link

Lib is returning an error for task not implemented #45

Closed NicolasMahe closed 4 years ago

NicolasMahe commented 5 years ago

The lib is returning an error when a task is defined in the service definition but not in the service code itself. Is it something we want to keep? A developer reports this on discord.

If we keep it, the error message should be way more explicit and maybe just a warning.

@antho1404 @ilgooz

https://github.com/mesg-foundation/mesg-js/blob/e14bfba6809582763476202d88aace2f0a799bbe/src/service/service.ts#L76-L79

antho1404 commented 5 years ago

This is necessary to check but I agree maybe an error is too much and a warning might be enough. A warning like that might be better The following tasks described in your mesg.yml are not implemented: ...