search

mesg-foundation / mesg.com

MESG's website
https://mesg.com
Apache License 2.0
2 stars 2 forks source link

Install menu component #221

Closed EmmanuelDrouin closed 4 years ago

EmmanuelDrouin commented 4 years ago
mesg-bot commented 4 years ago

Deploy preview for mesg ready!

Built with commit 21e9547a26768cd54fe54cd9fc66cf5c1078c35c

https://deploy-preview-221--mesg.netlify.com

EmmanuelDrouin commented 4 years ago

Todo:

EmmanuelDrouin commented 4 years ago

@antho1404 ready for review

antho1404 commented 4 years ago

The getStarted button triggers a full refresh of the page and shouldn't, probably not using a nuxt link.

EmmanuelDrouin commented 4 years ago

The getStarted button triggers a full refresh of the page and shouldn't, probably not using a nuxt link.

@antho1404 I found the issue, it come from the component. The button is set to an href instead of a to that's why is not a nuxt-link.

Fixed it in this PR https://github.com/mesg-foundation/mesg-components/pull/104.

Waiting for you to review it.

EmmanuelDrouin commented 4 years ago

Todo:

EmmanuelDrouin commented 4 years ago

@antho1404 PR ready for review