Update link CTA menu get started

mesg-foundation / mesg.com

MESG's website

https://mesg.com

Apache License 2.0

2 stars 2 forks source link

Update link CTA menu get started #241

Closed EmmanuelDrouin closed 4 years ago

EmmanuelDrouin commented 4 years ago

Replace internal link of the "get started" CTA in the menu by an external link to the get started page of the docs

To do:

[x] Fix issue with the "menu" component @antho1404 External links are not working if they are at the first level of the menu. They are working if they are at the second level of the menu (submenu)

mesg-bot commented 4 years ago

Deploy preview for mesg ready!

Built with commit 6005ff1a419666023171c09a202b74833421ea13

https://deploy-preview-241--mesg.netlify.app

antho1404 commented 4 years ago

@EmmanuelDrouin fix done, now the button can accept external links as well

EmmanuelDrouin commented 4 years ago

@antho1404 the issue is still here. The button in the menu is still not working with external links. I've double check, every components are up to date. But the issue remains.

I don't think the issue comes from the button. Every external links at the first level of the menu are not working. They are working only if they are in a sub-menu.

antho1404 commented 4 years ago

It's working for me https://deploy-preview-241--mesg.netlify.app/ Make sure to refresh your cache maybe (cmd+shift+r)

EmmanuelDrouin commented 4 years ago

@antho1404 i can see on the deploy-preview it's working. For me it's not working locally (on my localhost), even with the cache refreshed. I don't know why. But anyway looks good on the preview, so let's merge this PR and move on.

antho1404 commented 4 years ago

For information, it's probably because of your previous install

rm -rf node_modules
npm i

This should fix your issue