search

mesh-adaptation / animate

Anisotropic mesh adaptation toolkit for Firedrake
MIT License
6 stars 0 forks source link

updated firedrake import for triplot #74

Closed acse-ej321 closed 8 months ago

acse-ej321 commented 8 months ago

added updated import statement for firdrake.pyplot triplot for existing demos for issue #74

jwallwork23 commented 8 months ago

Thanks for this. We'll need to do the same for Goalie, too. The reason the tests fail is that I need to update the Docker container. Will aim to do that soon and then this can go through. https://github.com/pyroteus/animate/pull/47 would be a longer-term solution.

jwallwork23 commented 8 months ago

By the way, I think the issue you are referring to is #73. When you open the PR, if you start the text block with "Closes #73." then GitHub will link the issue to the PR so that once the PR is merged the issue is automatically closed. Sadly, this only works when you first create the PR, not if you edit the text. However, you can also link them by clicking the cog symbol next to "Development" in the right hand pane.