search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Add simple ODE demo #101

Closed jwallwork23 closed 6 months ago

jwallwork23 commented 6 months ago

Closes #100.

Also introduces a new PointSeq class for use with ODE problems.

jwallwork23 commented 6 months ago

Test suite seems to be failing for the same reason currently under investigation in #104.

jwallwork23 commented 6 months ago

@ddundo Since you mentioned you'd already been looking at this, would you be happy to review it?

jwallwork23 commented 6 months ago

Thanks for the review @ddundo. I think I addressed all your concerns. Also used float(sol) instead of sol.dat.data[0] for simplicity and to avoid exposing underlying Firedrake data structures in an early demo.

ddundo commented 6 months ago

Thanks @jwallwork23, I think this is much clearer now!