search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

#98: Add adaptor_kwargs to fixed point iteration #102

Closed ddundo closed 6 months ago

ddundo commented 6 months ago

Closes #98.

Small pull request to allow kwargs to be passed to the adaptor function in fixed_point_iteration. I am not 100% convinced myself how useful this is, as I suggested it for purely aesthetic purposes - e.g. if we have the adaptor function defined in a different script. But even then a similar thing may be achieved with factory pattern, for example, with the current goalie code. So feel free to reject this @jwallwork23 if you'd prefer not to change the goalie code for this!

ddundo commented 6 months ago

Thanks Joe! I actually cancelled the workflow here since I thought they're irrelevant changes :) I'm not sure if it would fail otherwise!

jwallwork23 commented 6 months ago

Thanks Joe! I actually cancelled the workflow here :) I'm not sure if it would fail otherwise!

How do you mean? I would recommend always running the tests in a PR, otherwise we might miss something. I re-triggered the tests that you cancelled and found that they failed for reasons unrelated to this PR (as mentioned above).

ddundo commented 6 months ago

Sorry about that! I'll go ahead and merge this then :)