mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Run test suite regularly #104

Closed jwallwork23 closed 6 months ago

jwallwork23 commented 6 months ago

Closes #103.

jwallwork23 commented 6 months ago

Hm I thought the problem was that files created during testing now hang around on GitHub Actions, rather than getting deleted. Combine that with a bug in the path for TestPVD ($(pwd)/tmp.pvd vs. $(pwd)/tmp/tmp.pvd) and it would explain why test_create_directory couldn't call rmdir on $(pwd)/tmp.

However, after deleting the subdir once it is there again the next time I trigger the CI. I can't see how TestPVD (or anything else) might be creating it. Rather confusing.

jwallwork23 commented 6 months ago

@stephankramer Would you mind reviewing this? It includes fixes required for other PRs to pass tests. Thanks!

jwallwork23 commented 6 months ago

Thanks!