search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Issue when using SWE mixed function space - checking `project` function source #107

Closed acse-ej321 closed 4 months ago

acse-ej321 commented 5 months ago

@jwallwork23 - I hit an error when running goal-based adaptation with two time-partitions with a SWE mixed-function space. The error originated from firedrake project and I noticed you have implemented an override of project in goalie.

Is the project implemented here setup to handle mixed function spaces?

https://github.com/pyroteus/goalie/blob/472e496d284ad0e8db4b6f1076bf29504adc8b7e/goalie/adjoint.py#L383-L387

jwallwork23 commented 5 months ago

Ah I see what you mean. I think this does indeed need to use Goalie's projection approach. If you could open a PR for this it'd be much appreciated!