107 mixed space adj project

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake

Other

1 stars 1 forks source link

Closed acse-ej321 closed 4 months ago

acse-ej321 commented 5 months ago

fixes #107 Calls the override project function instead of the default Firedrake function to deal with mixed function spaces and adjoints.

Additionally, modifies the creation of the enriched mesh to:

pass inherited parameters correctly in the constructor
force population of self._fs variable required for mesh-to-mesh conservative transfer

jwallwork23 commented 5 months ago

@acse-ej321 Apologies for pushing to your branch but I thought it would be easier than explaining my suggestion. What do you think of these changes?

update_function_spaces becomes the method that actually does the update.
function_spaces remains a property pointing to the underlying function spaces.

jwallwork23 commented 4 months ago

@acse-ej321 Are you happy to merge this? It's good to go. (Usually I leave merging to the developer.)