search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
2 stars 0 forks source link

Consistent time_partition variable #142

Closed ddundo closed 5 months ago

ddundo commented 8 months ago

@jwallwork23, I saw in #116 that you renamed P = mesh_seq.time_partition to tp = mesh_seq.time_partition. Is this what you'd prefer going forward?

jwallwork23 commented 8 months ago

Yeah single character variable names are bad practice in general. It's probably okay for fields in demo code (e.g., u, p) that have a clear mathematical usage, but we should avoid them as far as possible.

jwallwork23 commented 8 months ago

tp also more clearly means time partition than P.

ddundo commented 8 months ago

Thanks! :)