search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Parallel-safe counting #143

Closed ddundo closed 2 months ago

ddundo commented 4 months ago

Closes #123.

@jwallwork23, I had to remove the part of conftest.py which configures the settings for the parallel-marked tests. I hope that's okay? I couldn't get the test to pass with it. This way it seems to use settings from the firedrake import - like we are doing in animate parallel tests?

ddundo commented 4 months ago

Thanks for this @ddundo. I don't understand how the parallel tests still work after you removing the conftest code, though. How does it know what pytest.mark.parallel means? Is it because you use -n auto?

Nope, it passes without -n auto as well, I just thought that would speed up the testing and I saw the same in the animate's makefile :) I guess someone somewhere added the mark. I thought you'd know since animate doesn't configure pytest.mark.parallel anywhere either, unless I am missing it? I will investigate tomorrow and address your comments - thanks for reviewing this!

jwallwork23 commented 3 months ago

Hm yeah this must've got put inside pytest-mpi. Well, good to know that it wasn't needed anyway!

In that case, this PR will be good to go once you've addressed the requests above. Cheers.

ddundo commented 2 months ago

@jwallwork23 sorry for the delay with this - wanted to focus on more exciting PRs :) ready for review again